Ticket #11092 (closed Feature Requests: Obsolete)

Opened 4 years ago

Last modified 22 months ago

[TheTVDB Scraper] Decimals not recognized/supported in dvd order

Reported by: paendorz Owned by:
Priority: 4 - Normal Milestone:
Component: Scraper (Music/Video Metadata collector) Version: 10.0 "Dharma"
Severity: Normal Keywords:
Cc: jmarshall, olympia, vdrfan, spiff Blocked By:
Blocking: Platform: All
Revision:

Description

 http://forum.xbmc.org/showthread.php?t=90798

XML example attached to the ticket.

Attachments

en.xml Download (490.3 KB) - added by paendorz 4 years ago.

Change History

Changed 4 years ago by paendorz

comment:1 Changed 4 years ago by jmarshall

  • Cc olympia, vdrfan added

@olympia - any ideas from our scraper expert?

comment:2 Changed 4 years ago by olympia

Please update to tvdb scraper 1.1.0 and try if it is any better.

comment:3 Changed 4 years ago by paendorz

Nothing.

Only the first part is scraped: 1.3 for episode 1, 2.1 for episode 2, etc. (data from the attached file)

Unless I'm naming it wrong.

comment:4 Changed 4 years ago by olympia

Hmmm, the scraper should scrape it correctly now. Please provide a dummy file structure on which I can run some tests

comment:5 Changed 4 years ago by paendorz

Hmmm.

I've enabled DVD order and been using a dummy file called Animaniacs.s01e1.4.avi and different decimal variations (1.5, 1.6, 2.1, 2.2) with no luck.

Not sure if it helps.

comment:6 Changed 4 years ago by olympia

You have to use s01e01. Decimals from the filename will not be extracted and recognized.

comment:7 Changed 4 years ago by olympia

  • Cc spiff added

Ah, wait I see the issue now, but I don't think it's a scraper issue.

vdrfan, spiff? Do you have any idea how to resolve this? I suppose we would need to modify the file name cleaning regex for this (if at all possible) and I don't even know if it gets matched with the scraper results currently.

comment:8 Changed 4 years ago by paendorz

Any news?

comment:9 follow-up: ↓ 10 Changed 3 years ago by olympia

@paendorz

do you have any other example show than the one you linked? Or this is the only show with such a weird numbering on tvdb? :)

comment:10 in reply to: ↑ 9 Changed 3 years ago by paendorz

Replying to olympia:

@paendorz

do you have any other example show than the one you linked? Or this is the only show with such a weird numbering on tvdb? :)

 http://forum.xbmc.org/showpost.php?p=694927&postcount=14

comment:11 Changed 3 years ago by barcoboy

Having the same problem. I also noticed that it also occurs when using .nfo files. I have a two part episode of "The Real Ghostbusters" in a file named "S4E17.1E17.2 - Trading Faces - Transcendental Tourists.avi". Without an .nfo file, episode 17.1 gets scraped and imported as episode 17. I then created the following .nfo file:

<episodedetails>

<title>Trading Faces</title> <season>4</season> <episode>17.1</episode> <plot>A bullying ghost resembling Slimer escapes from the Ghostworld through an antique mirror, then traps Slimer and Louis in Ghostworld.</plot> <credits>Len Janson / Chuck Menville</credits> <aired>1989-11-18</aired> <studio>ABC</studio>

</episodedetails>

<episodedetails>

<title>Transcendental Tourists</title> <season>4</season> <episode>17.2</episode> <plot>Peter, Winston and Slimer head for Mount Rushmore on a much-anticipated vacation. However, a ghost family on their centennial holiday want the place all to themselves!</plot> <credits>Len Janson / Chuck Menville</credits> <aired>1989-11-18</aired> <studio>ABC</studio>

</episodedetails>

I can see that XBMC is using the information in the .nfo file, as if I reverse the order of the two entries, it will pick up the entry for 17.2 and import it as episode 17, but then 17.1 doesn't get picked up.

Link to thetvdb.com episode list:  http://www.thetvdb.com/index.php?tab=season&seriesid=71824&seasonid=3061&lid=7&order=dvd

comment:12 Changed 3 years ago by paendorz

Any news on this issue?

comment:13 Changed 3 years ago by barcoboy

Just downloaded the first beta of Eden, but it looks like this issue is still present. Any progress on this?

comment:14 Changed 3 years ago by Rad_

I can see how this is a difficult problem to solve elegantly, but would it be at all easier to work around this by allowing per-series selection/override of aired vs. dvd order through the context menu?

comment:15 Changed 2 years ago by SoWErA

Discovered this trac today when I looked at the changelog of thetvdb. Yesterday I posted a new trac about this or a similiar dvd order scraping issue: #12780 awaiting reply.

comment:16 follow-up: ↓ 17 Changed 2 years ago by jmarshall

@spiff: What's supposed to happen in this case? I believe we have no problem scraping the decimals, but they'll be scraped as integers, which will mean we're missing information for "episode" 1.2 etc.

comment:17 in reply to: ↑ 16 Changed 2 years ago by paendorz

Replying to jmarshall:

@spiff: What's supposed to happen in this case? I believe we have no problem scraping the decimals, but they'll be scraped as integers, which will mean we're missing information for "episode" 1.2 etc.

I could be wrong but I think those episodes are supposed to be merged into one. The titles, if anything.

comment:18 Changed 2 years ago by spiff

we're gonna fail badly. as you say, we're atoi'ing those numbers, so we will end up with '1'

comment:19 Changed 2 years ago by SoWErA

I found this thread about the same issue.

They got some nice idea's maybe you can use 1 of these?

 http://community.mediabrowser.tv/permalinks/870/sort-by-dvd-or-absolute-order

comment:20 Changed 2 years ago by SoWErA

I think I figured out a pretty nice and simple update to the dvd order scraping issue from thetvdb:

Merge decimals that ain't "*.0" since we know all episodes are 1.0 , 2.0 , 3.0 except for those that are suppose to be merged according to thetvdb which are for example 1.1 , 1.2 , 1.3 that should be merged as 1.0 and 21.1 , 21.2 as 21.0 while pulling togheter the info from all decimal parts and displaying as a combined title and plot from all decimal episodes. So we can all finally use dvd order again correctly. Maybe even add a dupe title check and if both titles are for example: "Children of the Gods (1)" , "Children of the Gods (2)" then it removes 1 dupe when merging and on all merges add " & " between titles so it becomes: "Children of the Gods (1) & (2)" or something similiar(perhaps first and last none dupe title part) but you decide. And between merged plots I would say 1 or 2 line breaks between would be a nice view of merged plots but up to you.

Unlike what I earlier requested this should be pretty simple to rewrite the dvd order scraping in thetvdb scraper.

Now I am obviously no coder but this should be possibole without to much work?

example
file/foldername   decimal format on thetvdb       added in xbmc as
s01e01                  => 1.1                     => 1 (eps 1 merged 3 titles and 3 plots)
s01e02                  => 1.2                     => 1 -||-
s01e03                  => 1.3                     => 1 -||-
s01e04                  => 2.0                     => 2
s07e20                  => 20.0                    => 20
s07e21                  => 21.1                    => 21 (eps 21 merged 2 titles and 2 plots)
s07e22                  => 21.2                    => 21 -||-}}}

comment:21 Changed 2 years ago by SoWErA

still no news? :(

Another tvshow that "thetvdb" added as part episodes with decimals: Falling Skies s2!

s02e02 1.2 s02e03 2.0 .....

There has to be a way for you guys to rewrite the code to check for 1.1 1.2 1.3 1.* until none found and then merge those episode into 1 by asking for the data from thetvdb for all episode and then combining the info into 1 long info and taking the thumbnail from the first one. Same with the title just ask "thetvdb" for all titles and then merge them with a + in between or something.

comment:22 Changed 22 months ago by Martijn

  • Resolution set to Obsolete
  • Milestone Future / Pending deleted

feature request are now handled through the XBMC forum

comment:23 Changed 22 months ago by Martijn

  • Status changed from new to closed
Note: See TracTickets for help on using tickets.