Ticket #11715 (closed Feature Requests: Fixed)

Opened 3 years ago

Last modified 12 months ago

Subtitle toast improvement

Reported by: sialivi Owned by: ace20022
Priority: 3 Milestone: 13.0 "Gotham"
Component: Subtitles Version: GIT
Severity: Normal Keywords:
Cc: vdrfan, Montellese, ace20022 Blocked By:
Blocking: Platform: All
Revision:

Description

When toggling between subtitles ('l') the messages in the "toast" isn't always very user friendly. Example:

I have an .mkv file which contain multiple internal PGS subtitles in various languages. The track names are unfortunatly only set to "PGS", but the language fields are properly set. I also have two external subtitle present: a.quite.long.filename.for.this.example.English.srt and a.quite.long.filename.for.this.example.Director's Commentary.srt, using the common <moviename>.<language or track name>.srt naming convention.

When toggling between the subtitles this is the information shown in the "toast" (also note that the filenames shown are truncated and none of the skins I've used scroll this text):

  • "PGS"
  • "PGS"
  • "PGS"
  • "a.quite.long.filen..."
  • "a.quite.long.filen..."
  • "Disabled"

Not very helpful. Something like this would be far more useful:

  • "PGS (English)"
  • "PGS (Swedish)"
  • "PGS (Spanish)"
  • "English" or "English (a.quite.long.filename.for.this.example.English.srt)
  • "Director's Commentary" or "Director's Commentary (a.quite.long.filename.for.this.example.Director's Commentary.srt)
  • "Disabled"

Change History

comment:1 Changed 3 years ago by sialivi

Sample file with multiple embedded PGS subtitles and external .srt:  http://www.mediafire.com/?mc3ocvp72cmr97p

comment:2 Changed 3 years ago by vdrfan

  • Cc vdrfan added

comment:3 Changed 3 years ago by Github Janitor

changed: ensure we're displaying the subtitle language when switching/selecting subtitles (partially addresses #11715)

Currently we're only displaying the subtitle name which is not neccessarily the actual subtitle language. This change takes care of the region code found in the subtitle stream. In case the language is different to the subtitle name it is appended to the string (eg. 'subtitle1 [English]').

Changeset: 57be7138d04c265882ee7b50b07f3950e676786d By: vdrfan

comment:4 Changed 3 years ago by Github Janitor

changed: ensure we're displaying the subtitle language when switching/selecting subtitles (partially addresses #11715)

Currently we're only displaying the subtitle name which is not neccessarily the actual subtitle language. This change takes care of the region code found in the subtitle stream. In case the language is different to the subtitle name it is appended to the string (eg. 'subtitle1 [English]').

Changeset: 57be7138d04c265882ee7b50b07f3950e676786d By: vdrfan

comment:5 Changed 3 years ago by jmarshall

  • Owner set to vdrfan
  • Status changed from new to assigned

What still needs doing for this one?

comment:6 Changed 2 years ago by sho

  • Cc Montellese, added

ping vdrfan. Also see #13085

comment:7 follow-up: ↓ 8 Changed 2 years ago by vdrfan

This ticket was _just_ addressing the formatting shown in the toast dialog. The other ticket is a FR for a "choose subtitle" dialog, isn't it?

comment:8 in reply to: ↑ 7 Changed 2 years ago by sialivi

Replying to vdrfan:

This ticket was _just_ addressing the formatting shown in the toast dialog. The other ticket is a FR for a "choose subtitle" dialog, isn't it?

Dialog and formatting

comment:9 Changed 2 years ago by Martijn

  • Priority changed from 4 - Normal to 3

is this still an issue?

if possible try to replicate using a latest nightly build so we can see if this is still an issue for upcoming release.  http://mirrors.xbmc.org/nightlies/

Make sure you backup your userdata folder before doing so or test on a separate machine

comment:10 Changed 2 years ago by sialivi

It is still an issue. I believe the following PR will adress this,  https://github.com/xbmc/xbmc/pull/1365

comment:11 Changed 21 months ago by Martijn

  • Milestone changed from Future / Pending to 13.0

comment:12 Changed 12 months ago by vdrfan

  • Cc ace20022 added; removed
  • Owner vdrfan deleted
  • Status changed from assigned to new

@ace20022, is this resolved with your work on external subtitle flag detection?

comment:13 follow-up: ↓ 14 Changed 12 months ago by ace20022

  • Owner set to ace20022
  • Status changed from new to accepted

The external subs part should be done.Not sure about the PGS part. @sialivi could you please re-check?

comment:14 in reply to: ↑ 13 ; follow-up: ↓ 15 Changed 12 months ago by sialivi

Replying to ace20022:

The external subs part should be done.Not sure about the PGS part. @sialivi could you please re-check?

That part has been fixed; a subtitle with a title and language set will be displayed as "English - Director's Commentary"

However, there is no indication whether or not a subtitle is internal or external, which gets confusing when you have media which have both:

I have lots of Movies with internal and external English subtitles and both will be listed simply as "English", so I have no idea which one I have selected.

Secondly, subtitles (and audio tracks) with long titles will still be truncated in the toast. Movies with multiple audio commentaries tend to have fairly long titles which lists the commentators for each track: "English - Commentary with Director James Cameron and..."

comment:15 in reply to: ↑ 14 Changed 12 months ago by ace20022

Replying to sialivi:

Replying to ace20022:

The external subs part should be done.Not sure about the PGS part. @sialivi could you please re-check?

That part has been fixed; a subtitle with a title and language set will be displayed as "English - Director's Commentary"

However, there is no indication whether or not a subtitle is internal or external, which gets confusing when you have media which have both:

I have lots of Movies with internal and external English subtitles and both will be listed simply as "English", so I have no idea which one I have selected.

ok, that's another thing, I think I will add ext. to the label.

Secondly, subtitles (and audio tracks) with long titles will still be truncated in the toast. Movies with multiple audio commentaries tend to have fairly long titles which lists the commentators for each track: "English - Commentary with Director James Cameron and..."

I guess that's skin related.

What about the pgs part? Can we close this ticket?

comment:16 Changed 12 months ago by sialivi

Yes, the PGS part (a subtitle with a title and language set) has been fixed. It's now displayed as "<language> - <title>".

comment:17 Changed 12 months ago by ace20022

  • Status changed from accepted to closed
  • Resolution set to Fixed

Thanks!

Note: See TracTickets for help on using tickets.