Ticket #12633 (closed Bugs: Obsolete)

Opened 2 years ago

Last modified 13 months ago

libasap compilation failure with gdc 4.6.2

Reported by: HellFire Owned by:
Priority: 4 - Normal Milestone:
Component: Build System Version: GIT
Severity: Normal Keywords:
Cc: theuni, Blocked By:
Blocking: Platform: All
Revision:

Description

libasap fails to build with:

make -C xasm
make[3]: Entering directory `/build/buildd/xbmc-11.0~beta3/lib/asap/xasm'
make[3]: warning: jobserver unavailable: using -j1.  Add `+' to parent make rule.
gdc -c -o xasm.o -O2 xasm.d
xasm.d:551: a != 0 must be parenthesized when next to operator &
xasm.d:551: b >= 32 must be parenthesized when next to operator &
make[3]: *** [xasm.o] Error 1

Looking at the code, it looks like line 551 should be:

if (a != 0 && b >= 32) {

and not

if (a != 0 & b >= 32) {

Affects Eden and master.

Attachments

asap-fixes.patch Download (1.6 KB) - added by HellFire 19 months ago.
Corrects line 551 and allows compiling with older versions of gdc

Change History

comment:1 Changed 19 months ago by Martijn

still problem with latest master?

Changed 19 months ago by HellFire

Corrects line 551 and allows compiling with older versions of gdc

comment:2 Changed 19 months ago by HellFire

Still fails. I've looked at it more, seems there was a lot of changes in 4.6 that broke it; compiles fine with 4.4. Attached patch corrects line 551 and adds support for building with older versions of gdc.

comment:3 Changed 19 months ago by Martijn

We prefer patches on github so all devs can review them better. If possible could you open up a PR there?  https://github.com/xbmc/xbmc

comment:4 Changed 16 months ago by Martijn

  • Cc theuni, added

@theuni Not sure who to cc so picked you ;)

comment:5 Changed 13 months ago by Martijn

  • Status changed from new to closed
  • Resolution set to Obsolete
  • Component changed from Other (un-categorized) to Build System
  • Milestone Future / Pending deleted

no response so closing

Note: See TracTickets for help on using tickets.