Ticket #6393 (closed Patches: Committed)

Opened 5 years ago

Last modified 5 years ago

Audio and Subtitle Delay GUIs (similar to volume control)

Reported by: ubikdood Owned by: Jezz_X
Priority: 4 - Normal Milestone: 9.11 "Camelot"
Component: Graphical User Interface (GUI) Version: GIT
Severity: Normal Keywords: gui subtitle audio delay
Cc: Jezz_X Blocked By:
Blocking: Platform: All
Revision:

Description

When user changes audio delay or subtitle delay pressing the appropriate key (or remote control button), a small dialog pops-up showing the delay in milliseconds. This functionality is very similar to the volume dialog. It's a quicker alternative to opening the audio/subtitle settings menu.

Attachments

DelayGUIs.tar.gz Download (7.1 KB) - added by ubikdood 5 years ago.
tar.gz containg patch and extra required files
DelayGUIs.patch Download (8.6 KB) - added by spiff 5 years ago.
DelayGUIs.2.patch Download (16.4 KB) - added by ubikdood 5 years ago.
Correct patch including new classes (sorry for wasting time)

Change History

Changed 5 years ago by ubikdood

tar.gz containg patch and extra required files

Changed 5 years ago by spiff

comment:1 follow-up: ↓ 2 Changed 5 years ago by spiff

new dialog code seems to be missing

Changed 5 years ago by ubikdood

Correct patch including new classes (sorry for wasting time)

comment:2 in reply to: ↑ 1 Changed 5 years ago by ubikdood

Replying to spiff:

new dialog code seems to be missing

Uploaded new patch, containing new dialog code. Forgot to "svn add" prior to "svn diff", sorry...

comment:3 Changed 5 years ago by Jezz_X

  • Cc Jezz_X added

comment:4 Changed 5 years ago by jmarshall

Nice work. A couple of comments:

  1. Do we really need a separate dialog for these? Perhaps we could simply make a boolean condition available instead on change of these things and the skinner could then add it wherever they like? i.e. instead of calling Show() on the window, we call into the infomanager and set a flag. The idea would be to have a set of flags indexed by the info id in the infomanager, and just set that.
  1. If we are having a window, I don't think you need to call OnAction() after Show() as the timer will be reset anyway, right? I presume the call is instead to force the timer to reset (see 3)
  1. We have auto-close code in the base class CGUIDialog already, that I think will take care of 2.

comment:5 Changed 5 years ago by spiff

  • Cc Jezz_X removed
  • Status changed from new to closed
  • Resolution set to Commited to SVN
  • Milestone changed from 9.04 to 9.10

r19962. cheers! i hadn't even realized how much this was needed :)

only did a minor adjustment; removed the prefix on the labels as that should be up to the skin.

and hurrah, i went ahead and commited before i saw jmarshall's comments :/

comment:6 Changed 5 years ago by spiff

  • Status changed from closed to reopened
  • Resolution Commited to SVN deleted

comment:7 Changed 5 years ago by spiff

  • Cc Jezz_X added

comment:8 Changed 5 years ago by jmarshall

  • Owner set to Jezz_X
  • Status changed from reopened to assigned

r20053 takes care of the cleanup stuff - skin just needs doing now.

comment:9 Changed 5 years ago by Jezz_X

  • Status changed from assigned to closed
  • Resolution set to Commited to SVN

Skin side for both default skins added

Note: See TracTickets for help on using tickets.